Make inverting Y axis optional (with non-breaking default)#9
Merged
Conversation
Owner
|
Amazing! Thanks so much ❤️ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 51.46% 51.95% +0.49%
==========================================
Files 2 2
Lines 581 587 +6
==========================================
+ Hits 299 305 +6
Misses 282 282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklockwood
pushed a commit
that referenced
this pull request
Dec 21, 2025
Contributor
Author
|
@nicklockwood Did you accidentally remove the change to SVGPath+CoreGraphics.swift when or after you merged this? |
Owner
|
I deliberately removed it - I don't think it's necesary to have that option when creating a CGPath from a String since you can use the convenience API available directly on SwiftUI.Path, or use the CGPath.from(SVGPath) version if you need an inverted CGPath for some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3, this pull request allows setting parse options such that the y-axis will not be flipped, and it defaults to flipping, so this is not a breaking change.
I implemented this in the exact same format as the author's WriteOptions struct to be consistent.
I've used this with success to render kanji characters in SVG format.