Add a standard self-contained favicon to all generated pages - #62
Open
zereraz wants to merge 1 commit into
Open
Conversation
- SKILL.md: add favicon to delivery rules + final checklist, plus a KaTeX '<'-escaping note that prevents formula truncation - templates: add the data-URI favicon to all 4 reference templates - extension.ts: ensureFavicon() deterministically injects the favicon after </title> (or into <head>) on render unless an icon link already exists, so pages get it even if the agent omits it The favicon is a self-contained data-URI SVG (node-graph glyph, dark/accent palette), consistent with the self-contained-HTML requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every generated page (decks, diagrams, reports) currently ships without a favicon, so browser tabs show the blank default. This adds a standard, self-contained data-URI favicon — a small node-graph glyph in the dark/accent palette, consistent with the self-contained-HTML requirement (no external file).
Changes
<as<inside$$...$$(a bare<makes the HTML parser truncate the formula).<link>added to all 4 reference templates.ensureFavicon()deterministically injects the favicon after</title>(or into<head>) on render, unless aniconlink already exists — so pages get it even if the model omits it. Idempotent; preserves any existing icon.Notes
icon, existingshortcut icon).