Fix/landing page availability#14
Merged
Merged
Conversation
landing page was not reachable with network mode host
the docker socket under /var/run was not the one beeing used in NixOS. This prevented the use of docker to start the open-wrt container for the 'Time Travelers Update'-CTF challenge from inside the landing page container.
There was a problem hiding this comment.
Pull request overview
This PR adjusts the devcontainer “virtual” docker-compose setup to improve the availability/behavior of the landing service by changing how it connects to the host and Docker daemon.
Changes:
- Removed
network_mode: hostfrom thelandingservice and kept an explicit80:80port mapping. - Switched the
landingservice’s Docker socket bind mount from/var/run/docker.sockto${XDG_RUNTIME_DIR}/docker.sock.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
niklashaug
reviewed
May 5, 2026
niklashaug
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
details: see commit messages