chore(gate): CREW-14 — bun run check builds to a temp dir, never rewrites the committed bundle - #27
Merged
Merged
Conversation
…e untouched Wrap the build step in check script with mktemp -d to build to a temporary directory instead of the committed packages/extension/dist/. This prevents bun run check from dirtying the committed bundle on macOS builds. The --outdir override is passed directly to bun build, which honors it. Default behavior (plain bun run build) remains unchanged for release flow.
…caveat 1. Rename CHECK_OUT local variable (was TMPDIR) to avoid confusion with the environment variable that tools read — landmine for future editors. 2. Update CLAUDE.md bundle caveat to document that bun run check no longer touches the committed dist (builds to temp dir instead).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Running the documented full gate (
bun run check) on macOS rewrote the committedpackages/extension/dist/index.jswith a platform-shimmed bundle that CLAUDE.md then tells you not to commit. This papercut is how a contaminated commit happened during the fix wave.Change
Two-line total: the check script builds to a fresh
mktemp -doutput (variable named CHECK_OUT — deliberately not TMPDIR, which is a real env var tools read) and cleans it up; plainbun run buildand CI's linux-x64bundle-checkare untouched. One clarifying line added to CLAUDE.md's bundle caveat.Evidence
Note for the maintainer