fix(nikcli): solve Windows-specific ESM require, JSON schema, log cleanup, and Git ceiling test failures - #71
Merged
Conversation
…anup, and Git ceiling test failures
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Owner
|
| Detail | Value |
|---|---|
| Failed step | Unknown step |
| Autofix status | ⏭️ Autofix skipped |
| Run | View full logs |
Failure Summary
(no summary available)
Please inspect the full Actions logs for complete output. Do not share this comment publicly — it may contain redacted paths.
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves several critical Windows-specific bugs that block successful testing and execution: 1. ESM Require Resolution: Added createRequire to packages/nikcli/src/file/watcher.ts. 2. JSON Schema undefined handling: Stripped undefined keys in returned session objects. 3. Environment isolation: Reset process.env in test/preload.ts. 4. Directory cleanup safety: Handled ENOENT during background log sweeps in src/util/log.ts. 5. Git traversal boundary: Set GIT_CEILING_DIRECTORIES = os.tmpdir() to prevent search from hitting user's home folder.