perf(shell): optimize PowerShell detection to prevent false positives on Windows - #72
Merged
Merged
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Owner
|
| Detail | Value |
|---|---|
| Failed step | Unknown step |
| Autofix status | ⏭️ Autofix skipped |
| Run | View full logs |
Failure Summary
(no summary available)
Please inspect the full Actions logs for complete output. Do not share this comment publicly — it may contain redacted paths.
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the PowerShell command detection in
packages/nikcli/src/shell/shell.tson Windows.Problem
Previously, any command referencing standard environment variables using the
$symbol (such asecho $PATHorexport FOO=$BAR) was incorrectly flagged as a PowerShell command, forcingnikclito spawnpowershell.exeunder the hood.Because
powershell.exehas high startup latency (0.5s to 2.0s due to .NET CLR and profile loading), this caused a severe lag of 1-2 seconds per command. Moreover, Unix-style commands likeexport FOO=$BARwould fail completely under PowerShell.Solution
/\$(?:\w+|{[^}]+})/regex fromPOWERSHELL_MARKERS.$PSVersionTable,$profile,$true,$false,$null,$args,$input,$Matches).