fix(nikcli): solve startup package re-install loop and correct TypeScript typecheck errors - #73
Merged
Merged
Conversation
…t TypeScript typecheck compile errors
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
`@nikcli-ai/inference` defines a `typecheck` script using `tsgo` but never declared `@typescript/native-preview`, so the binary was missing and the pre-push workspace typecheck failed with "command not found: tsgo". Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Owner
|
/nik fixa tutto |
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #77
Also fixes #76 (workspace typecheck failing because
packages/inferencewas missing thetsgodependency).Type of change
What does this PR do?
Two things:
@typescript/native-previewdevDependency topackages/inferenceso itstsgotypecheck script can actually run. Without it the workspace typecheck failed with exit 127 (command not found), which is what was breaking CI on this branch.How did you verify your code works?
Ran
turbo run typecheckacross the workspace — all 21 packages pass. Verifiedpackages/inferencetypecheck now runs instead of failing with 127, and that nikcli startup no longer re-enters the install loop.Checklist