Rebuild NILMbench as a reproducible real-data benchmark - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nilmbenchCLIProtocol findings
The recovered notebooks and paper disagree in several places: REDD T1 asks for data before the canonical file begins; REFIT T1 requests an unavailable microwave; REDD T2 MAE uses building 4 while the F1 notebook and paper use building 6; and notebook F1 uses NILMTK's fixed 10 W threshold although the paper specifies appliance thresholds. Historical profiles preserve those inputs for forensic reproduction. Corrected profiles use the paper splits, strict coverage, per-appliance alignment, and explicit thresholds.
NILM Metadata remains responsible for semantic interoperability. NILMbench adds only experiment-level configuration and provenance; it does not maintain a competing appliance alias table.
Verification
pytest: 9 passedruff check src tests: passeduv lock --check: passeddocker compose config --quiet: passedDependency
This PR is intentionally stacked on nilmtk/nilmtk-contrib#100 and pins commit
f152f9f1783161bced09da7239d7ad57f4196a9bin the Python lock and container workflow.