Tests for derived quantities feature#1548
Merged
Merged
Conversation
Member
|
@kenkellner I reviewed all the tests again. Only one minor comment, noting the presence of one remaining "TODO" note on line 494. I'm not sure if that still needs to be addressed or not, but otherwise this LGTM and ready to merge into |
danielturek
approved these changes
May 29, 2025
Member
danielturek
left a comment
danielturek
left a comment
There was a problem hiding this comment.
TODO comment on line 494, does that need to be addressed?
Contributor
Author
|
Thanks, that last TODO should have been deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for the new derived quantities feature.