Skip to content

Conversation

@leeronr
Copy link

@leeronr leeronr commented May 18, 2016

spm.interface.preprocess.Coregister’s _format_arg function was
creating incorrect input parameters resulting in an infinite loop.

"estwrite" was not taken into account and Input parameter "target"
should be called with default keep4d=False in order to appropriately
create the "ref" parameter for MATLAB.

spm.interface.preprocess.Coregister’s _format_arg  function was
creating incorrect input parameters resulting in an infinite loop.

"estwrite" was not taken into account and Input parameter "target"
should be called with default keep4d=False in order to appropriately
create the "ref" parameter for MATLAB.
return scans_for_fnames(val)
return super(Coregister, self)._format_arg(opt, spec, val)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra spaces.

@satra
Copy link
Member

satra commented May 30, 2016

thanks for this - can you add a bit of explanation for the keep4d=False switch?

@satra
Copy link
Member

satra commented Jul 12, 2016

@leeronr - checking if you can provide some explanation for the keep4d=False switch

@djarecka
Copy link
Collaborator

@leeronr - thanks again for pr, could you please explain the keep4d=False switch so we can review it.

@djarecka
Copy link
Collaborator

@leeronr - please let us know if you're planning to work on this PR, otherwise I'll try to review and finish.

@effigies
Copy link
Member

This pull request is "orphaned," which means it has been deemed to be abandoned by its original author. Orphaned pull requests have not been rejected, and we hope that if a user sees one that will meet their needs with a little work, that they will fork it and open a new pull request (or, in the case of the original author, reopen the original PR).

We ask that all adopted PRs be updated to merge or rebase the current master. If you would like to adopt a PR and need help getting started, any of a number of contributors will be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants