Some minor fixes to actors examples#2401
Merged
privat merged 4 commits intonitlang:masterfrom Apr 5, 2017
Merged
Conversation
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
xymus
approved these changes
Mar 30, 2017
|
|
||
| var i = count.length - 1 | ||
| while i > 0 do | ||
| for i in [0..(count.length - 1)].reverse_iterator do |
Contributor
Author
There was a problem hiding this comment.
lol I'm dumb haha !
| end | ||
| end | ||
| for j in [0..i] do p[j] = if j + d <= i then pp[j+d] else pp[j+d-i-1] | ||
| i -= 1 |
Contributor
There was a problem hiding this comment.
i is set at the next iteration of the for loop anyway... Or is there something I'm missing?
Contributor
Author
There was a problem hiding this comment.
wasnt looking at the same line hahahah, you're right
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
BlackMinou
force-pushed
the
actors
branch
2 times, most recently
from
fd81ee7 to
beffce2
Compare
Merged
privat
approved these changes
Apr 5, 2017
privat
added a commit
that referenced
this pull request
Apr 5, 2017
Tried to follow @tremblay-guy commentaries on #2361 to improve the code of the actors examples Pull-Request: #2401 Reviewed-by: Alexis Laferrière <alexis.laf@xymus.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to follow @tremblay-guy commentaries on #2361 to improve the code of the actors examples