Merged
Conversation
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
Signed-off-by: BlackMinou <romain.chanoir@viacesi.fr>
jcbrinfo
reviewed
Apr 4, 2017
| # | ||
| # The object are finialized in a topological order, it is safe for this method | ||
| # to use attributes of this instances. | ||
| # The object are not finialized in a topological order, it is safe for this method |
Contributor
There was a problem hiding this comment.
This sentence should end at the first comma IMHO. Example:
The objects are not finialized in a topological order. It is safe for this method […]
Contributor
Author
There was a problem hiding this comment.
I think it's ok ...
xymus
approved these changes
Apr 4, 2017
Contributor
xymus
left a comment
xymus
left a comment
There was a problem hiding this comment.
This change was overdue, thanks!
privat
approved these changes
Apr 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the actor model where the GC is unable to collect cycles associated with actors objects and printing an annoying warning
Theses modifs should fix the tests in #2401
The downside is that the finalization is no longer in topological order