Skip to content

fix: remove "5 min to midnight" banner from doomsday strip#81

Merged
nitrocode merged 1 commit into
mainfrom
copilot/remove-5-min-to-midnight-banner
Apr 26, 2026
Merged

fix: remove "5 min to midnight" banner from doomsday strip#81
nitrocode merged 1 commit into
mainfrom
copilot/remove-5-min-to-midnight-banner

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

The "X.X MIN TO MIDNIGHT" text in the doomsday strip was confusing without adding meaningful information — the clock hand and progress bar already convey proximity to the threshold visually.

Changes

  • index.html — Removed the #doomTimeText element from the doomsday strip
  • src/js/18-scary-features.js — Removed the minsLeft calculation and doomTimeText update block from updateDoomsdayClock()
  • styles/scary-features.css — Removed the now-orphaned .doomsday-time rule

Summary by CodeRabbit

  • User Interface
    • Simplified the Doomsday Clock display to show only the percentage indicator, removing the "MIN TO MIDNIGHT" countdown text.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 245faac8-e2b0-410d-b4d8-8d8c5e6d17dc

📥 Commits

Reviewing files that changed from the base of the PR and between 200e880 and 9af6e8d.

📒 Files selected for processing (3)
  • index.html
  • src/js/18-scary-features.js
  • styles/scary-features.css
💤 Files with no reviewable changes (3)
  • styles/scary-features.css
  • src/js/18-scary-features.js
  • index.html

📝 Walkthrough

Walkthrough

Sucka! This PR removes the Doomsday Clock time display feature by eliminating the HTML time text element, the JavaScript calculations and DOM updates that populated it, and the associated CSS styling class. I pity the fool who doesn't track this removal!

Changes

Cohort / File(s) Summary
Doomsday Clock Time Display Removal
index.html, src/js/18-scary-features.js, styles/scary-features.css
Removes the time-to-midnight display component entirely: deletes the #doomTimeText HTML node, strips out the minsLeft calculation and DOM update logic from updateDoomsdayClock(), and eliminates the .doomsday-time CSS styling block. Fool, the percentage subtext display remains intact!

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • nitrocode

Jibber jabber, sucka! This here's a clean, straightforward removal with tight cohesion across all three files. Ain't no fancy logic changes or nothing—just deletions. I pity the fool who takes longer than five minutes reviewin' this one!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the '5 MIN TO MIDNIGHT' text display from the doomsday clock component, which is reflected across all three modified files (HTML, JavaScript, and CSS).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/remove-5-min-to-midnight-banner

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

👁️ PR Preview

🚀 Open Preview

Deployed from commit 9af6e8d · Updates on every push to this PR
(Preview is removed automatically when the PR is closed.)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (200e880) to head (9af6e8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          242       242           
  Branches       109       109           
=========================================
  Hits           242       242           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200e880...9af6e8d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nitrocode nitrocode merged commit 9da8e57 into main Apr 26, 2026
10 checks passed
@nitrocode nitrocode deleted the copilot/remove-5-min-to-midnight-banner branch April 26, 2026 16:28
github-actions Bot added a commit that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants