fix: remove doomsday clock strip banner

[Copilot]

• Remove #doomsday-strip HTML block from index.html
• Remove updateDoomsdayClock() function + constants from src/js/18-scary-features.js
• Extract dismiss button wiring into initEmergencyBroadcast() (keeps emergency broadcast overlay working)
• Remove updateDoomsdayClock(tokens) call from src/js/02-counter.js
• Replace initDoomsdayClock() with initEmergencyBroadcast() in src/js/21-boot.js
• Remove doomsday strip CSS from styles/scary-features.css
• Merge main into branch — conflict resolved, kept floating stat pops from main
• Fix unit tests — removed leftover updateDoomsdayClock call that survived the merge (all 268 tests pass)

Summary by CodeRabbit

• New Features

  • Emergency Broadcast Overlay providing an improved notification interface with customizable dismissible controls and integrated automatic timer management for enhanced user experience.

• Refactor

  • Replaced legacy Doomsday Clock display with modernized Emergency Broadcast Overlay featuring enhanced styling and improved user interaction patterns.
  • Optimized counter update performance by eliminating redundant per-frame processing calculations, improving overall application responsiveness.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a351737-a0cd-4b74-ba1e-b6e0fa2cde89

📥 Commits

Reviewing files that changed from the base of the PR and between 25f776e and 1baffbb.

📒 Files selected for processing (5)

• index.html
• src/js/02-counter.js
• src/js/18-scary-features.js
• src/js/21-boot.js
• styles/scary-features.css

💤 Files with no reviewable changes (3)

• src/js/02-counter.js
• styles/scary-features.css
• index.html

🚧 Files skipped from review as they are similar to previous changes (1)

• src/js/21-boot.js

---

📝 Walkthrough

Walkthrough

Removed the Doomsday Clock UI and its per-frame updates; replaced the Doomsday initializer with an emergency broadcast initializer that registers a dismiss handler. Bootstrap now starts the emergency broadcast instead of the doomsday clock.

Changes

Cohort / File(s)	Summary
HTML UI index.html	Removed the Doomsday Clock DOM: container #doomsday-strip, clock SVG/hand, percentage display, and progress bar elements.
Counter Loop src/js/02-counter.js	Removed the per-frame call to updateDoomsdayClock(tokens) from updateCounters(), stopping continuous doomsday UI updates.
Feature Module src/js/18-scary-features.js	Removed Doomsday Clock logic and initializer; added initEmergencyBroadcast() which wires the overlay dismiss button and clears the auto-dismiss timer.
Bootstrap src/js/21-boot.js	Replaced call to initDoomsdayClock() with initEmergencyBroadcast() in the app init() sequence.
Stylesheet styles/scary-features.css	Deleted all Doomsday Clock-related CSS rules (layout, clock SVG styling, progress bar, responsive tweaks, and reduced-motion overrides).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: growing token rate + floating +N pop animation on total counter #76 — Also modifies src/js/02-counter.js; relates to changes in counter update logic and token-pop behavior.
• fix: remove "5 min to midnight" banner from doomsday strip #81 — Overlaps edits to Doomsday Clock UI and related JS/CSS; similar removals/adjustments to the same feature.

Suggested reviewers

• nitrocode

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: remove doomsday clock strip banner' directly and accurately summarizes the main change: removal of the doomsday clock UI component across all affected files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch copilot/remove-clock-and-threshold-banner

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

👁️ PR Preview

🚀 Open Preview

Deployed from commit 1baffbb · Updates on every push to this PR
(Preview is removed automatically when the PR is closed.)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0495b0d) to head (1baffbb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          242       242           
  Branches       109       109           
=========================================
  Hits           242       242           

Flag	Coverage Δ
unit	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0495b0d...1baffbb. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nitrocode]

@copilot resolve the merge conflicts in this pull request

[Copilot]

@copilot resolve the merge conflicts in this pull request

Resolved in bb9cb41. The only conflict was in src/js/02-counter.js — main had added floating stat pops alongside the updateDoomsdayClock call. I kept the floating pops and dropped the updateDoomsdayClock call. All 268 tests pass.