types: export missing h3 types from runtime - #4378
Conversation
|
@lachieh is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthrough
Changesh3 type re-export expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
Fixes #4344
❓ Type of change
📚 Description
When using a dependency manager that uses a symlink strategy such as
pnpm,bun, ornpmwith the--install-strategy=linkedflag, TypeScript will flag the types that come from these module paths as non-portable, which is correct.This PR exports the types that are depended upon by the exported h3 helpers.
The alternative is making h3 a peerDependency or documenting that users install "h3" as a direct dependent of their project, but that feels like a lot more hoop-jumping when h3 is so integral to nitro.
📝 Checklist