fix(vite): pass aliases as ordered entries so specific keys win - #4537
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Nitro Vite plugin converts bundler aliases into ordered Vite alias entries. A fixture and integration test verify alias resolution for Rolldown, Rollup, and Vite builders. ChangesVite alias precedence
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change makes specific Vite aliases take precedence as intended and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
❓ Type of change
📚 Description
spotted this issue in nuxt - although nitro correctly orders aliases, vite ignores the order when it merges with other config that's passed to it.
this is a hotfix - we can also look to try to resolve this in vite itself.
📝 Checklist