fix(presets): keep srvx/body-limit out of the bare srvx alias in standard - #4538
Conversation
The `standard` preset aliases bare `srvx` to `srvx/generic`. That alias prefix-matches, so subpaths resolve against the generic adapter's file rather than the package, which is why `srvx/node`, `srvx/generic` and `srvx/tracing` are already listed explicitly. srvx 0.12 adds a `./body-limit` export and h3 imports it, so without an entry `srvx/body-limit` resolves to `dist/adapters/generic.mjs/body-limit` and the build fails with UNLOADABLE_DEPENDENCY. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@ShreeBohara is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe standard Nitro preset now aliases ChangesStandard preset alias
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized preset change corrects subpath resolution for the body-limit export; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
srvx/body-limit out of the bare srvx aliassrvx/body-limit out of the bare srvx alias
srvx/body-limit out of the bare srvx aliassrvx/body-limit out of the bare srvx alias in standard
commit: |
🔗 Linked issue
Not a separate issue. This is what #4521 is failing on.
❓ Type of change
📚 Description
The
standardpreset aliases baresrvxtosrvx/generic. That alias prefix-matches, so any subpath resolves against the generic adapter's file instead of the package. Thesrvx/node,srvx/genericandsrvx/tracingentries sitting next to it are there to work around exactly that.srvx 0.12 adds a
./body-limitexport and h3 imports it, so on any branch that bumps srvx the build dies:Adding the entry fixes it. On #4521's dependency set that takes the suite from 116 failures to 100; the remaining 100 are unrelated to this (mostly basic-auth assertions that need updating for h3 now sending
charset="UTF-8", plus the bundle size budgets).On main this changes nothing, since srvx 0.11 has no
body-limitexport and nothing imports it. Full suite on main with the patch is unchanged at 903 passing, with the one pre-existingbump-versiondate failure.📝 Checklist