Skip to content

fix(firebase): Use a Set for supported node versions - #929

Closed
luc122c wants to merge 1 commit into
nitrojs:mainfrom
luc122c:main
Closed

fix(firebase): Use a Set for supported node versions#929
luc122c wants to merge 1 commit into
nitrojs:mainfrom
luc122c:main

Conversation

@luc122c

@luc122c luc122c commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Error:   69:9  error  `supportedNodeVersions` should be a `Set`, and use `supportedNodeVersions.has()` to check existence or non-existence  unicorn/prefer-set-has

Pr #925 introduced a lint error. This PR fixes it.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@luc122c

luc122c commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

@pi0 this should fix the CI error I introduced.

@pi0

pi0 commented Feb 8, 2023

Copy link
Copy Markdown
Member

Pushed to main before see your pr. thanks anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants