Skip to content

Conversation

@brckd
Copy link
Contributor

@brckd brckd commented Feb 26, 2025

Description

This adds the programs.godot module with support for editor configurations and text editor themes. It's accompanied by the godot library module which exposes constructors for godot data types.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

This adds the `programs.godot` module with support for editor
configurations and text editor themes. It's accompanied by the `godot`
library module which exposes constructors for godot data types.
@brckd
Copy link
Contributor Author

brckd commented Feb 26, 2025

Nevermind, Godot seems to override the editor settings file. Declaring text themes work, but they have to be manually selected for that reason.

@0xda157
Copy link
Contributor

0xda157 commented May 10, 2025

Nevermind, Godot seems to override the editor settings file. Declaring text themes work, but they have to be manually selected for that reason.

Maybe you could try do something similar to #6940?

@brckd
Copy link
Contributor Author

brckd commented May 10, 2025

Nevermind, Godot seems to override the editor settings file. Declaring text themes work, but they have to be manually selected for that reason.

Maybe you could try do something similar to #6940?

Sure, that might work, but then all Godot settings have to be set via Home Manager. I thought about creating an overlay that overrides the default settings, but couldn't them.

@stale
Copy link

stale bot commented Aug 8, 2025

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Aug 8, 2025
@brckd brckd closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants