Generating report fails on Thinkpad X1 Carbon Gen5

[gorschu]

Describe the bug

When trying to generate a JSON report on a - rather old - Thinkpad Carbon X1 facter dies almost instantly with

2024/12/16 17:30:54 root.go:120: failed to scan: failed to scan hardware: failed to read input devices: failed to annotate with udev data: failed to parse bus: rmi does not belong to Bus values

Passing in something minimal like --hardware cpu does not seem to change behavior.

To Reproduce

sudo nix run --option experimental-features "nix-command flakes" nixpkgs#nixos-facter -- --log-level=debug -o facter.json

Expected behavior

A facter.json report is being generated.

System information

• Thinkpad X1 Carbon Gen5
• NixOS BUILD_ID="25.05.20241213.3566ab7"

Additional context

Running the same command on my Thinkpad P14s Gen2 on the same software stack works just fine and produces a facter.json report.

[brianmcgee]

rmi is not a supported value in this Bus enum: https://github.com/numtide/nixos-facter/blob/bf95127c44b86845769bf00687efc4f78b0a985f/pkg/udev/udev.go#L56-L75

I can't remember where I got that list from, I believe it was from udev source. I'll find some time in the next couple days to have a closer look and try to ensure full coverage of that field type.

[gorschu]

@brianmcgee thanks a lot. Nothing pressing on my side, just stumbled upon this issue when resurrecting that old laptop from the shelf. ;)

[brianmcgee]

@gorschu can you give #172 a try and see if it borks?

@Mic92 since I changed how I'm parsing the bus from udev, can you give it a run on the range of machines you have and check for issues and changes?

[gorschu]

@brianmcgee checked out both current main and #172 directly, still same unsupported bus type: Rmi error, unfortunately.

[brianmcgee]

Ok, I was looking in the wrong place for this. The problem is here:

nixos-facter/pkg/hwinfo/input.go

Lines 100 to 105 in afc5ca2

	input.BusRmi,
	input.BusCec,
	input.BusIntelIshtp,
	input.BusAmdSfh:
	// todo unsure if touchpads can be on any other bus type
	return nil, fmt.Errorf("unsupported bus type: %s", inputDevice.Bus)

[brianmcgee]

It looks like you have a touchpad using the RMI bus.