feat: use linux input Bus enum with udev data #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why I created a separate Bus enum for udev. From the source, as best I can tell, it's using https://github.com/systemd/systemd/blob/8e3347f3bd3d9a01b8f39b0858eab74084ecf20a/src/basic/linux/input.h#L252-L275. This aligns with that and should fix #166. Signed-off-by: Brian McGee <brian@bmcgee.ie>
This was referenced Jan 8, 2025
Member
|
Starting to test. |
Mic92
approved these changes
Jan 8, 2025
Member
|
Couldn't find a regression, also I didn't experienced the original bug. |
Contributor
|
@Mic92 looks like there is an issue with adding new repos to buildbot, it added the webhook but hasn't updated https://buildbot.nix-community.org/#/projects and this PR wasn't built. |
Member
|
I may have seen this issue. I think it currently only adds projects after restart. |
Contributor
Yes, was added after restart. |
Member
|
Buildbot has some code for reload projects, maybe a bug on our side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why I created a separate Bus enum for udev. From the source, as best I can tell, it's using https://github.com/systemd/systemd/blob/8e3347f3bd3d9a01b8f39b0858eab74084ecf20a/src/basic/linux/input.h#L252-L275.
This aligns with that and should fix #166.
Closes #166
Closes #171