Add missing copyright notices to SBOM#5241
Merged
Merged
Conversation
Contributor
Author
|
@nlohmann I was usure about the |
According to the README file and the git history, code from the Apache 2.0 library "Abseil" was copy-pasted into the cpp_future.hpp file. Despite this, their license was not specified in the SPDX specification causing it to be missing in the SBOM. They were however already noted as co-authors of the file. This commit adds them to correct the generated SBOM. Signed-off-by: Daniel Falk <Daniel.Falk.1@FixedIT.ai>
daniel-falk
force-pushed
the
fix-reuse-missing-license
branch
from
5b239ac to
b6b9e77
Compare
nlohmann
added
the
🚀 ready to merge
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the README file and the git history, code from the Apache 2.0 library "Abseil" was copy-pasted into the cpp_future.hpp file. Despite this, their license was not specified in the SPDX specification causing it to be missing in the SBOM. They were however already noted as co-authors of the file.
This commit adds them to correct the generated SBOM.
No README update is needed since it already explains this.
[Describe your pull request here. Please read the text below the line and make sure you follow the checklist.]
make amalgamate.Read the Contribution Guidelines for detailed information.