Documentation review: fix stale compiler-exclusion list#5258
Merged
Conversation
PR #5248 added a 5th JSON_HAS_RANGES exclusion branch to macro_scope.hpp (nvcc CUDA 12.0.x/12.1.x, fixed in 12.2, issue #3907) shortly after #5252 added the "Known compiler/stdlib exclusions" list to json_has_ranges.md, so the new branch was missing from the just-added doc section. Bring the list back to parity with the code (5 exclusion branches, 5 documented). Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up documentation pass after #5257, checking activity merged into
developsince then.json_has_ranges.md: Document compiler/stdlib exclusions in macro_scope.hpp #5252 added a "Known compiler/stdlib exclusions" list forJSON_HAS_RANGES(4 entries), but Fix nvcc CUDA 12.0/12.1 C++20 ranges parse error (#3907) #5248 — merged less than 2 hours later — added a 5th exclusion branch tomacro_scope.hpp(nvcc CUDA 12.0.x/12.1.x, fixed in CUDA 12.2, issue error: expected initializer before ‘<’ token #3907) as part of unrelated work fixing the underlying nvcc parse error. The doc page never caught up. This restores parity: verified viamacro_scope.hppthat there are exactly 5#elif-chainedJSON_HAS_RANGESexclusion branches in code, now exactly 5 documented.Test plan
include/nlohmann/detail/macro_scope.hppmatches the bullet count in the doc page.🤖 Generated with Claude Code