Skip to content

Use correct flags to determine fragmented or reassembled packets. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JasonStephenson wants to merge 1 commit into from
Closed

Use correct flags to determine fragmented or reassembled packets. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 29 additions & 25 deletions packetWin7/npf/npf/Loopback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,61 +341,65 @@ NPF_NetworkClassify(
COMPARTMENT_ID compartmentID = UNSPECIFIED_COMPARTMENT_ID;
FWPS_PACKET_INJECTION_STATE injectionState = FWPS_PACKET_INJECTION_STATE_MAX;
PNET_BUFFER_LIST pClonedNetBufferList = NULL;
UINT32 layerFlags = 0;

#if(NTDDI_VERSION >= NTDDI_WIN7)
UNREFERENCED_PARAMETER(classifyContext);
#endif
UNREFERENCED_PARAMETER(filter);
UNREFERENCED_PARAMETER(flowContext);

TRACE_ENTER();

// Make the default action.
if (classifyOut->rights & FWPS_RIGHT_ACTION_WRITE)
classifyOut->actionType = FWP_ACTION_CONTINUE;

// Filter out fragment packets and reassembled packets.
if (inMetaValues->currentMetadataValues & FWP_CONDITION_FLAG_IS_FRAGMENT)
//Set runtime variables from the layer
if (inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V4)
{
return;
layerFlags = inFixedValues->incomingValue[FWPS_FIELD_OUTBOUND_IPPACKET_V4_FLAGS].value.uint32;
bIPv4 = TRUE;
bInbound = FALSE;
}
#if(NTDDI_VERSION >= NTDDI_VISTASP1)
if (inMetaValues->currentMetadataValues & FWP_CONDITION_FLAG_IS_REASSEMBLED)
else if (inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V4)
{
return;
layerFlags = inFixedValues->incomingValue[FWPS_FIELD_INBOUND_IPPACKET_V4_FLAGS].value.uint32;
bIPv4 = TRUE;
bInbound = TRUE;
}
#endif

TRACE_ENTER();

// Get the packet protocol (IPv4 or IPv6) and the direction (Inbound or Outbound).
if (inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V4 || inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V4)
else if (inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V6)
{
bIPv4 = TRUE;
layerFlags = inFixedValues->incomingValue[FWPS_FIELD_OUTBOUND_IPPACKET_V6_FLAGS].value.uint32;
bIPv4 = FALSE;
bInbound = FALSE;
}
else if (inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V6 || inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V6)
else if (inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V6)
{
layerFlags = inFixedValues->incomingValue[FWPS_FIELD_INBOUND_IPPACKET_V6_FLAGS].value.uint32;
bIPv4 = FALSE;
bInbound = TRUE;
}
else
{
TRACE_MESSAGE1(PACKET_DEBUG_LOUD,
"NPF_NetworkClassify: bIPv4 cannot be determined, inFixedValues->layerId = %d\n", inFixedValues->layerId);
"NPF_NetworkClassify: Unsupported layer. Runtime values cannot be determined, inFixedValues->layerId = %d\n", inFixedValues->layerId);
layerFlags = 0;
bIPv4 = FALSE;
}

if (inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V4 || inFixedValues->layerId == FWPS_LAYER_OUTBOUND_IPPACKET_V6)
{
bInbound = FALSE;
}
else if (inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V4 || inFixedValues->layerId == FWPS_LAYER_INBOUND_IPPACKET_V6)

// Filter out fragment packets and reassembled packets.
if (layerFlags & FWP_CONDITION_FLAG_IS_FRAGMENT)
{
bInbound = TRUE;
return;
}
else
#if(NTDDI_VERSION >= NTDDI_VISTASP1)
if (layerFlags & FWP_CONDITION_FLAG_IS_REASSEMBLED)
{
TRACE_MESSAGE1(PACKET_DEBUG_LOUD,
"NPF_NetworkClassify: bInbound cannot be determined, inFixedValues->layerId = %d\n", inFixedValues->layerId);
bInbound = FALSE;
return;
}
#endif

if (inMetaValues->currentMetadataValues & FWPS_METADATA_FIELD_IP_HEADER_SIZE)
{
Expand Down