fix: distinguish a stored nil from a missing key in fetch/2 - #20
Merged
Conversation
fetch/2 was implemented on top of get/3, so a key holding nil came back as :error — indistinguishable from a key that was never set. That defeats the only reason fetch/2 exists alongside get/3. Read from ETS directly in fetch/2 and define get/3 in terms of it, so there is a single lookup site. The cost is unchanged: one registry read for the table id, one :ets.lookup/2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
fetch/2was implemented on top ofget/3, a key holdingnilwas reported as:error— indistinguishable from a key that was never set:That defeats the only reason
fetch/2exists alongsideget/3.fetch/2now reads from ETS directly andget/3is defined in terms of it, so there is a single lookup site. Cost is unchanged: one registry read for the table id, one:ets.lookup/2.Covered by a test asserting a stored
niland a missing key are told apart.