Motion becomes a value - #149
Open
nmbrthirteen wants to merge 1 commit into
Open
Conversation
Every part of a clip moved according to numbers written into its own component: hormozi sprang with damping 12, subtle slid eight pixels over six frames, the name card faded over eight. Changing any of it meant editing a component, which is the same as saying it could not be changed. It is four values now — enter, exit, duration, feel — attached to a part and nothing else. Four, not a keyframe timeline: every move a short actually makes is in that list, and a timeline is a surface people open once. If something real cannot be said this way, that is the argument for keyframes, and not before. Each style ships the motion it already had, so this changes nothing on its own. Verified by hash: hormozi, karaoke, subtle and branded all render the same frame before and after, and an overridden motion renders a different one. Carried as one JSON value rather than a flag per property, because that is how it will arrive from a template.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #148.
Every part of a clip moved according to numbers written into its own component: hormozi sprang with
damping: 12, subtle slid eight pixels over six frames, the name card faded over eight. Changing any of it meant editing a component.Motion is four values now, attached to a part:
Four, not a keyframe timeline. Every move a short actually makes is in that list, and a timeline is a surface people open once. If something real cannot be said this way, that is the argument for keyframes, and not before.
This changes nothing on its own
Each style ships the motion it already had. Verified by frame hash at t=2s, before and after:
1a71d344…5f8e6c14…84d48965…6bba026c…All four identical. An overridden motion renders a different frame, which is the other half of the proof.
Carried as one value
--motion '{"captions":{"enter":"pop","exit":"sink","duration":8,"feel":"soft"}}'onprocess, and onemotioninput prop on the composition, because that is how it will arrive from a clip template rather than as a flag per property.