Say what podcli actually does, and report the real clips path#70
Conversation
The "What you get" list named six things. The repo ships considerably more: an asset library with intros, outros, and music; AssemblyAI as an alternative engine; yt-dlp URL import; laughter detection for highlight reels; transcript corrections; a command palette; thumbnail and content studios; YouTube analytics; DaVinci FCPXML export. Grouped into clips, finding the moments, the studio, and shipping. The tool count is stated as 26, which check-docs-drift.mjs verifies against server.tool call sites, so this claim cannot rot silently the way "22 tools" did. `doctor` printed cwd/podcli-clips unconditionally, even with PODCLI_OUTPUT set, so it misreported where renders land for anyone using the override. The backend has always honored the variable; only the report was wrong. Clips are per-directory by design: each show keeps its own renders while knowledge, presets, assets, history, and cache live in one managed folder. The README now says that outright, since the split is easy to mistake for an oversight.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR documents a new ChangesPODCLI_OUTPUT Support
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #69, which squash-merged before this commit landed on it.
The feature list undersold the project
"What you get" named six things. The repo ships considerably more, none of it mentioned: an asset library with intros, outros, and background music; AssemblyAI as an alternative engine; yt-dlp URL import; laughter detection for highlight reels; transcript corrections; the ⌘K command palette; the thumbnail and content studios; YouTube analytics; DaVinci FCPXML export; multi-segment cuts; audio normalization; presets; duplicate detection.
Everything is enumerated from source (26
server.toolregistrations, 12 studio routes) and grouped into clips, finding the moments, the studio, and shipping. The tool count is stated as 26, whichcheck-docs-drift.mjsverifies against the call sites, so it cannot rot silently the way "22 tools" did.doctorreported the wrong clips pathIt printed
cwd/podcli-clipsunconditionally, even withPODCLI_OUTPUTset, so anyone using the override was told the wrong directory. The backend has always honored the variable (backend/config/paths.py:47); only the report was wrong.This touches
cli/, so it reaches users on the next tag.Clips are per-directory on purpose
Verified against the released 2.4.2 binary from two working directories: renders go to
./podcli-clipseach time, while the managed home stays constant. Knowledge, presets, assets, history, and cache are unified and follow you between directories; only renders are per-show.engine.go:197states the intent. The README now says it outright, since the split reads like an oversight otherwise.Verification
check-docs-drift.mjsclean,go build/vet/testclean, bothdoctorbranches exercised, zero em or en dashes.Summary by CodeRabbit
Documentation
Bug Fixes