Skip to content

Conversation

@mmaiers-nmdp
Copy link
Contributor

This adds "W" and "exon" as redux levels
"W" is an expanding type (like MAC and XX) in that finds all WHO alleles consistent with the input.
"exon" is a reducing type, it expects input that is already exon (3field) resolution or higher (4 field) and reduces it to 3 field.

To covert 2-field/MAC/XX to exon/3-field resolution it requires calling redux_gl twice: once at W level to expand and then at exon level to reduce the output to exon/3-field

@mmaiers-nmdp
Copy link
Contributor Author

mmaiers-nmdp commented Aug 5, 2021

Before merging there are some issues with PR #103

  1. it doesn't work the first time the sqllite3 database is created but it does the 2nd time when it is read
  2. v2 support was removed because it led to infinite recursion and I didn't see a good general solution
  3. test cases are needed for "exon" and "W" resolution

Copy link
Contributor

@pbashyal-nmdp pbashyal-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following changes to the PR merged:
- Fix issue with returning who_group
- gc only for Python >= 3.9
- lru_cache size can be parameterized with max_cache_size
- Add tests for W and exon redux_types

@pbashyal-nmdp
Copy link
Contributor

Closing with commit 3809696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants