Skip to content

Conversation

@pbashyal-nmdp
Copy link
Contributor

Fix validation issues with:

  • empty alleles, eg. A*
  • NNNNs eg.DRB3*NNNNs
  • non-allelic values eg. A*0.559722222

Closes #103 #97 #93 and #95

@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Aug 25, 2021
@pbashyal-nmdp pbashyal-nmdp added this to the Version 0.7.0 milestone Aug 25, 2021
# validate allele without the 'HLA-' prefix
if HLA_regex.search(allele):
# remove 'HLA-' prefix
allele = allele[4:]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mmaiers-nmdp mmaiers-nmdp merged commit e2db90b into nmdp-bioinformatics:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation: Fails for empty allele Validation: Validate fp number py-ard considers 'DRB3*NNNN' v2 typing

2 participants