0.7.0 Version: Stricter Validation #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't return an empty string, return an Exception for invalid/non-existing alleles - Validate serology against the existing serology mapping in the database - Validate MAC against the existing MAC codes in the database
- convert to markdown - Reorganize for better readability
pbashyal-nmdp
added
bug
mmaiers-nmdp
requested changes
Oct 28, 2021
Contributor
mmaiers-nmdp
left a comment
mmaiers-nmdp
left a comment
There was a problem hiding this comment.
lets add a test for valid serology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stricter Validation:
README changes:
Bump version: 0.6.9 → 0.7.0
Use correct LICENSE file
Fixes #83
Fixes #88
Fixes #89
Fixes #90
Fixes #93
Fixes #95
Fixes #97
Fixes #98
Fixes #99
Fixes #100
Fixes #111