Skip to content

Conversation

@pbashyal-nmdp
Copy link
Contributor

  • If typing is '' return it as empty
  • If redux_gl fails, print it as problematic

Produce a summary of all problematic typings with column name.

Summary
-------
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.613194444' in column d_a_typ1
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.247916667' in column d_a_typ1
	 Failed reducing 'A*0.215972222' in column d_a_typ1
	 Failed reducing 'A*0.45994213' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ1
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ2

Fixes #96

- If typing is '' return it as empty
- If redux_gl fails, print it as problematic

Produce a summary of all problematic typings with column name.

```
Summary
-------
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.613194444' in column d_a_typ1
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.247916667' in column d_a_typ1
	 Failed reducing 'A*0.215972222' in column d_a_typ1
	 Failed reducing 'A*0.45994213' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ1
	 Failed reducing 'A*0.559722222' in column d_a_typ1
	 Failed reducing 'A*0.529166667' in column d_a_typ2
```

Fixes nmdp-bioinformatics#96
@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Jul 1, 2021
@pbashyal-nmdp pbashyal-nmdp added this to the Version 0.7.0 milestone Jul 1, 2021
Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmaiers-nmdp mmaiers-nmdp merged commit 00d6b10 into nmdp-bioinformatics:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validation: Add option to continue after failure in pyard-reduce-csv

2 participants