[feat] Add more key quantities needed for asar SIS exporter function

[sbreitbart-NOAA]

Add capability to calculate and store key quantities necessary for the in-development asar::export_to_sis() function

[github-actions]

New version checklist

• Package version in DESCRIPTION has been updated
• Release notes have been drafted/published
• Cheatsheet content has been updated (if applicable)
• Cheatsheet version has been updated

[github-actions]

Code Metrics Report

Coverage	Code to Test Ratio	Test Execution Time
68.1%	1:0.1	8m1s

Code coverage of files in pull request scope (81.1%)

Files	Coverage
R/plot_biomass.R	81.7%
R/plot_fishing_mortality.R	94.2%
R/save_all_plots.R	75.5%

---

Reported by octocov

[Schiano-NOAA]

Is there any way we can take this out of the function? I think this is making the function much longer than needed and it's not relevant to making the plot since it serves a different purpose.

[sbreitbart-NOAA]

Is there any way we can take this out of the function? I think this is making the function much longer than needed and it's not relevant to making the plot since it serves a different purpose.

What code/function are you talking about, specifically? All of it?

[Schiano-NOAA]

@sbreitbart-NOAA any of the key quantity calcs. I think it would be worth it to at least put them in their own function and call them in the plot_x function with the dat as input

[sbreitbart-NOAA]

@sbreitbart-NOAA any of the key quantity calcs. I think it would be worth it to at least put them in their own function and call them in the plot_x function with the dat as input

Ok, just made a new function calc_kqs() that calculates the key quantities in a few functions- primarily those that require more than a line to calculate- so the plotting functions aren't as long anymore. Is that sufficient re: your idea?

[Schiano-NOAA]

@sbreitbart-NOAA any of the key quantity calcs. I think it would be worth it to at least put them in their own function and call them in the plot_x function with the dat as input

Ok, just made a new function calc_kqs() that calculates the key quantities in a few functions- primarily those that require more than a line to calculate- so the plotting functions aren't as long anymore. Is that sufficient re: your idea?

Yes this is great. Cleans up the code well and we can still get the quantities we need efficiently 😄