refactor(convert_output): remove {httr} dependency and switch URL validation to base R - #305
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Refactor to eliminate {httr} using base R
refactor(convert_output): remove Jul 20, 2026
{httr} dependency and switch URL validation to base R
Schiano-NOAA
marked this pull request as ready for review
July 21, 2026 17:52
Schiano-NOAA
approved these changes
Jul 21, 2026
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Going to wait for checks to run before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_output()used{httr}only for URL existence checks, making{httr}an unnecessary runtime dependency. This PR replaces that check with base R (utils::curlGetHeaders) and removes{httr}from package imports.URL validation refactor (base R)
httr::HEAD()+httr::status_code()withutils::curlGetHeaders()inconvert_output().404and emittingcli::cli_abort("Invalid URL.").Dependency cleanup
httrfromDESCRIPTIONImports.Focused coverage update
testthatcase asserting an invalid URL input triggers"Invalid URL.".