Skip to content

Change the message of "error.consumption.validation.inheritedFromItem" when using canCreate#271

Merged
RuthDiG merged 9 commits intomainfrom
bugfix/change-errorMessage-of-CanCreate
Sep 18, 2024
Merged

Change the message of "error.consumption.validation.inheritedFromItem" when using canCreate#271
RuthDiG merged 9 commits intomainfrom
bugfix/change-errorMessage-of-CanCreate

Conversation

@RuthDiG
Copy link
Copy Markdown
Contributor

@RuthDiG RuthDiG commented Sep 13, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@RuthDiG RuthDiG added wip Work in Progress (blocks mergify from auto update the branch) refactoring Refactoring of code labels Sep 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/requests/outgoing/OutgoingRequestsController.ts 16.66% 5 Missing ⚠️
Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionCoreErrors.ts 80.11% <100.00%> (+0.23%) ⬆️
...consumption/src/modules/common/ValidationResult.ts 100.00% <100.00%> (ø)
...es/requests/outgoing/OutgoingRequestsController.ts 83.77% <16.66%> (-1.02%) ⬇️

@RuthDiG RuthDiG marked this pull request as ready for review September 17, 2024 07:30
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Sep 17, 2024
jkoenig134
jkoenig134 reviewed Sep 17, 2024
View reviewed changes
Comment thread packages/consumption/src/modules/requests/outgoing/OutgoingRequestsController.ts Outdated
Milena-Czierlinski
Milena-Czierlinski reviewed Sep 17, 2024
View reviewed changes
Comment thread packages/runtime/test/modules/DeciderModule.test.ts
jkoenig134
jkoenig134 reviewed Sep 17, 2024
View reviewed changes
Comment thread packages/consumption/src/modules/requests/outgoing/OutgoingRequestsController.ts Outdated
britsta
britsta reviewed Sep 17, 2024
View reviewed changes
Comment thread packages/consumption/src/consumption/ConsumptionCoreErrors.ts Outdated
@RuthDiG RuthDiG merged commit a65b798 into main Sep 18, 2024
@RuthDiG RuthDiG deleted the bugfix/change-errorMessage-of-CanCreate branch September 18, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@britsta britsta britsta left review comments

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski left review comments

+1 more reviewer

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactoring Refactoring of code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RuthDiG @jkoenig134 @britsta @Milena-Czierlinski