Skip to content

Password-protected RelationshipTemplates#295

Merged
Magnus-Kuhn merged 119 commits intomainfrom
password-protected-templates
Nov 26, 2024
Merged

Password-protected RelationshipTemplates#295
Magnus-Kuhn merged 119 commits intomainfrom
password-protected-templates

Conversation

@Magnus-Kuhn
Copy link
Copy Markdown
Contributor

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@Magnus-Kuhn Magnus-Kuhn added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Oct 14, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 78.93175% with 71 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ionshipTemplates/RelationshipTemplateController.ts 58.16% 40 Missing and 1 partial ⚠️
...ansport/src/core/types/SharedPasswordProtection.ts 72.09% 12 Missing ⚠️
...core/types/PasswordProtectionCreationParameters.ts 68.96% 9 Missing ⚠️
...tionshipTemplates/CreateOwnRelationshipTemplate.ts 75.00% 4 Missing ⚠️
...elationshipTemplates/RelationshipTemplateMapper.ts 50.00% 3 Missing ⚠️
...tes/CreateTokenQRCodeForOwnRelationshipTemplate.ts 80.00% 0 Missing and 1 partial ⚠️
...ationshipTemplates/LoadPeerRelationshipTemplate.ts 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
...taViews/consumption/PeerRelationshipTemplateDVO.ts 100.00% <100.00%> (ø)
...src/dataViews/transport/RelationshipTemplateDVO.ts 100.00% <100.00%> (ø)
...ime/src/types/transport/RelationshipTemplateDTO.ts 100.00% <100.00%> (ø)
...kages/runtime/src/useCases/common/RuntimeErrors.ts 79.77% <100.00%> (+0.30%) ⬆️
packages/runtime/src/useCases/common/Schemas.ts 100.00% <100.00%> (ø)
...ransport/account/LoadItemFromTruncatedReference.ts 98.37% <100.00%> (ø)
...Templates/CreateTokenForOwnRelationshipTemplate.ts 89.87% <100.00%> (+2.91%) ⬆️
packages/transport/src/core/Reference.ts 92.30% <100.00%> (+1.39%) ⬆️
packages/transport/src/core/TransportCoreErrors.ts 60.44% <100.00%> (+1.62%) ⬆️
...ges/transport/src/core/types/PasswordProtection.ts 100.00% <100.00%> (ø)
... and 14 more

... and 3 files with indirect coverage changes

@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review October 15, 2024 12:06
@Magnus-Kuhn Magnus-Kuhn removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 15, 2024
@Magnus-Kuhn Magnus-Kuhn marked this pull request as draft October 15, 2024 12:18
@Magnus-Kuhn Magnus-Kuhn marked this pull request as ready for review October 15, 2024 12:36
Comment thread .dev/compose.backbone.env Outdated
Co-authored-by: Julian König <33655937+jkoenig134@users.noreply.github.com>
Comment thread packages/transport/test/modules/tokens/TokenController.test.ts Outdated
Comment thread packages/runtime/test/transport/relationshipTemplates.test.ts Outdated
Comment thread packages/runtime/test/transport/relationshipTemplates.test.ts Outdated
Comment thread packages/runtime/test/transport/relationshipTemplates.test.ts Outdated
jkoenig134
jkoenig134 previously approved these changes Nov 21, 2024
jkoenig134
jkoenig134 previously approved these changes Nov 21, 2024
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @britsta and @Milena-Czierlinski please re-check the tests.

Comment thread packages/runtime/test/transport/relationshipTemplates.test.ts Outdated
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Magnus-Kuhn Magnus-Kuhn merged commit c89f944 into main Nov 26, 2024
@Magnus-Kuhn Magnus-Kuhn deleted the password-protected-templates branch November 26, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants