Skip to content

Remove FreeTextRequestItem#491

Merged
jkoenig134 merged 7 commits into
release/v7from
Remove-FreeTextRequestItem
Apr 28, 2025
Merged

Remove FreeTextRequestItem#491
jkoenig134 merged 7 commits into
release/v7from
Remove-FreeTextRequestItem

Conversation

@jkoenig134
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 commented Apr 28, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@jkoenig134 jkoenig134 added the breaking-change A breaking change label Apr 28, 2025
@jkoenig134 jkoenig134 changed the base branch from main to release/v7 April 28, 2025 10:40
@jkoenig134
Copy link
Copy Markdown
Contributor Author

@Milena-Czierlinski can you have a look at packages/runtime/test/modules/DeciderModule.test.ts? I don't really understand that test and the FreeText is heavily used here.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...nsumption/src/consumption/ConsumptionController.ts 96.77% <ø> (-0.06%) ⬇️
packages/consumption/src/modules/requests/index.ts 100.00% <ø> (ø)
packages/content/src/requests/RequestItem.ts 90.90% <ø> (+0.21%) ⬆️
packages/content/src/requests/items/index.ts 100.00% <ø> (ø)
...ontent/src/requests/response/AcceptResponseItem.ts 95.18% <ø> (-0.33%) ⬇️
packages/runtime/src/dataViews/DataViewExpander.ts 61.43% <ø> (+0.43%) ⬆️
...s/runtime/src/dataViews/content/RequestItemDVOs.ts 100.00% <ø> (ø)
.../runtime/src/dataViews/content/ResponseItemDVOs.ts 100.00% <ø> (ø)
packages/runtime/src/modules/DeciderModule.ts 92.66% <ø> (-0.06%) ⬇️
...ckages/runtime/src/modules/decide/RequestConfig.ts 100.00% <ø> (ø)
... and 2 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@britsta britsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (apart from the DeciderModule.test.ts test, which @Milena-Czierlinski will have a look at) 👍

@jkoenig134 jkoenig134 merged commit d80ea96 into release/v7 Apr 28, 2025
15 checks passed
@jkoenig134 jkoenig134 deleted the Remove-FreeTextRequestItem branch April 28, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants