Skip to content

Misleading error code used#532

Merged
britsta merged 2 commits into
release/v7from
fix/use-of-misleading-error-code
May 8, 2025
Merged

Misleading error code used#532
britsta merged 2 commits into
release/v7from
fix/use-of-misleading-error-code

Conversation

@britsta
Copy link
Copy Markdown
Contributor

@britsta britsta commented May 8, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

The invalidAcceptParameters error code should not be used if the accept parameters when trying to accept a RequestItem are valid but the RequestItem cannot be accepted for other reasons. Otherwise, the error code gives the impression that the recipient can change the fact that the RequestItem is not acceptable by using other accept parameters, which is not the case.

The invalidRequestItem error code may be appropriate instead if the RequestItem contains errors that should have been prevented on the sender side anyway. In other cases, more specific error messages could be used.

@britsta britsta added the bug Something isn't working label May 8, 2025
@britsta britsta requested a review from Milena-Czierlinski May 8, 2025 10:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rship/TransferFileOwnershipRequestItemProcessor.ts 60.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...rship/TransferFileOwnershipRequestItemProcessor.ts 88.23% <60.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@britsta britsta marked this pull request as ready for review May 8, 2025 10:42
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! :)

@britsta britsta merged commit 056b865 into release/v7 May 8, 2025
15 checks passed
@britsta britsta deleted the fix/use-of-misleading-error-code branch May 8, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants