Skip to content

Latest shared version of Attribute isn't returned if it has a successor that isn't shared#812

Merged
Milena-Czierlinski merged 11 commits into
mainfrom
fix-get-latest-shared-version
Oct 27, 2025
Merged

Latest shared version of Attribute isn't returned if it has a successor that isn't shared#812
Milena-Czierlinski merged 11 commits into
mainfrom
fix-get-latest-shared-version

Conversation

@Milena-Czierlinski
Copy link
Copy Markdown
Member

@Milena-Czierlinski Milena-Czierlinski commented Oct 24, 2025

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

@Milena-Czierlinski Milena-Czierlinski added wip Work in Progress (blocks mergify from auto update the branch) bug Something isn't working labels Oct 24, 2025
@Milena-Czierlinski Milena-Czierlinski removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 24, 2025
@Milena-Czierlinski Milena-Czierlinski marked this pull request as ready for review October 24, 2025 11:56
Comment thread packages/consumption/src/modules/attributes/AttributesController.ts Outdated
Comment thread packages/runtime/test/consumption/attributes.test.ts Outdated
Comment thread packages/runtime/test/consumption/attributes.test.ts Outdated
Comment thread packages/consumption/src/modules/attributes/AttributesController.ts Outdated
britsta
britsta previously approved these changes Oct 24, 2025
@Milena-Czierlinski Milena-Czierlinski merged commit 28aa600 into main Oct 27, 2025
15 checks passed
@Milena-Czierlinski Milena-Czierlinski deleted the fix-get-latest-shared-version branch October 27, 2025 10:54
Copy link
Copy Markdown
Contributor

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants