Skip to content

fix(cmake): use dependency targets for build-tree consumers #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liamnwhite1 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −12
Open

fix(cmake): use dependency targets for build-tree consumers #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,23 +175,21 @@ SET(HEADERS
# Create a single library for the project
add_library(geometry-central ${SRCS} ${HEADERS})

# Public headers include vendored headers directly, so build-tree consumers need
# those include roots explicitly. The install tree collapses them under the
# single installed include directory.
target_include_directories(geometry-central
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../include>
$<BUILD_INTERFACE:${EIGEN3_INCLUDE_DIR}>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../deps/happly>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

target_link_libraries(geometry-central
PUBLIC
$<BUILD_INTERFACE:Eigen3::Eigen>
$<BUILD_INTERFACE:happly>
PRIVATE
"${CMAKE_CURRENT_SOURCE_DIR}/../deps/nanoflann/include"
"${CMAKE_CURRENT_SOURCE_DIR}/../deps/nanort/include"
)
$<BUILD_INTERFACE:nanoflann>
$<BUILD_INTERFACE:nanort>)

# Keep Eigen out of the exported build-tree link interface to avoid exporting the
# local helper target created in deps/CMakeLists.txt. The installed package adds
# Eigen3::Eigen back after calling find_dependency(Eigen3).
# Keep build-tree dependency targets out of the installed export. The installed
# package adds Eigen3::Eigen back after calling find_dependency(Eigen3).

# Set compiler properties for the library
target_compile_features(geometry-central PUBLIC cxx_std_11)
Expand Down