fix: Added Batch operations. #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 49
💛 - Coveralls |
nodece
reviewed
May 7, 2020
nodece
reviewed
May 7, 2020
Contributor
|
Could you add transaction in When happens error, rollback and throw error. |
Contributor
|
Before PR, make commits is clean via squash and rebase. |
Member
divy9881
force-pushed
the
batch_operations
branch
3 times, most recently
from
7f25929 to
bfa4667
Compare
nodece
reviewed
May 8, 2020
nodece
reviewed
May 8, 2020
nodece
reviewed
May 8, 2020
nodece
reviewed
May 8, 2020
fix: Make operations transactional. fix: Replace manager with connection. fix: Rollback to getRepo. fix: test. fix: Made removePolicies transactional. fix: savePolicy(). fix: Added commit transactions. fix: throw err. fix: Commit transaction.
Contributor
Author
|
Thanks for pointing out, @nodece, so silly of me. |
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #21