"end" emitted after "error"

[tj]

is this a bug? I'm getting around it no problem by just setting a flag but I thought I would leave an issue

[joshrtay]

have you been able to get node-formidable working with the latest version of express? they were working together just fine until I updated express. (check out issue #108 for a simple example that's not working for me)

[tj]

@joshrtay bodyParser() uses formidable now, I need to add an option so it's not mandatory, but yeah it's unified into req.body now

[felixge]

@visionmedia No, I don't think that emitting 'end' after 'error' makes much sense. How can I reproduce this?

[joshrtay]

@visionmedia thanks

[tj]

weird, yeah i'll try and reproduce it stand-alone

[xsyn]

Hi, I've been trying to use the connect way of doing things, I did previously have it working with formidable, however I'm not getting a req.body.image at all.

I've gone through http://tjholowaychuk.com/post/12943975936/connect-1-8-0-multipart-support several times, and everything looks right.

npm says I'm using connect 1.8.2 and I'm using node v0.6.5

Any thoughts?

[tj]

@xsyn sorry about that, merging files to req.body was an oversight, they're available as req.files now to differentiate, because otherwise one could craft a request such as image[path]=/etc/passwd using x-www-form-urlencoded or similar with json, and depending on your app that could be a very bad thing

[thevinci]

Man. This hurts. Spent hours looking for this.

[tj]

@thevinci which? end after error? or the connect change? (changelogs are friends :D)

[thevinci]

Connect change. If I wanted to customize formidable how do I do that btw? I can't seem to find that anywhere.

On Dec 17, 2011, at 8:22 AM, TJ Holowaychukreply@reply.github.com wrote:

@thevinci which? end after error? or the connect change? (changelogs are friends :D)

---

Reply to this email directly or view it on GitHub:
#107 (comment)

[tj]

@thevinci http://senchalabs.github.com/connect/middleware-bodyParser.html

[tj]

this will be different in later versions (the three parsers are separated) but that's a quick fix for now

[thevinci]

Do I place this after or before app.use(express.bodyParser())

delete express.bodyParser.parse['multipart/form-data'];

I tried every possible combination and am having the same problem.

    var form = new formidable.IncomingForm();
    form.parse(req, function(err, fields, files) {
      console.log('HELLO');      
      res.writeHead(200, {'content-type': 'text/plain'});
      res.write('received upload:\n\n');
      res.end(sys.inspect({fields: fields, files: files}));
    });
    return;

It never triggers form.parse - never consoling 'HELLO'

[tj]

anywhere, that will remove the parser in 1.x so bodyParser wont even try to handle it

[niftylettuce]

is this still the way to resolve this?

edit: doesn't seem to work at all.. :(