Emit error on aborted connection#195
Merged
svnlto merged 1 commit intonode-formidable:masterfrom Feb 18, 2013
Merged
Conversation
Emit 'error' if connection is closed before request received fully. Adjust test-fixtures to postpone socket.close(). add standalone test case on connection aborted
svnlto
added a commit
that referenced
this pull request
Feb 18, 2013
Emit error on aborted connection
This was referenced Feb 18, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit 'error' if connection is closed before request received fully.
This is in a way similar to #145, however here 'aborted' is handled as event (and callback if given will be called on error). Make sure 'end' is not emitted if 'error' already emitted (fixes #107) and vice versa, 'error' is not emitted after 'end' - this means if connection is aborted after request body is fully parsed, formidable would not complain.