Fixes - #6
Merged
Merged
Conversation
Build the development bundle before starting the static test server, and probe bundle.js instead of the HTML shell so AVA cannot start while Rollup is still compiling. Also wait for the vis-bug custom element's shadow toolbar to be initialized before browser tests interact with it. This prevents the startup race that caused querySelector failures in the accessibility and box-shadow suites.
Register a built-in 3D transform selection action and command that replaces the standard selection overlays with four draggable projective corner handles. Compute and serialize perspective matrix3d transforms, preserve existing transforms and transform origins, and record each completed drag as a single undoable style change. Keep transform mode active across pointer release, exit cleanly on outside clicks, and normalize viewport coordinates for scrolled documents. Add unit and browser coverage for matrix generation, overlay switching, undo/redo, click behavior, and scrolling.
Stop margin and padding key handlers from hiding the selected handles for 750ms after every change, which made held-key adjustments appear frozen until input stopped. Reuse the existing box-model backdrop while refreshing handle geometry so transformed quad updates redraw the overlay in place. Clear reused backdrops when spacing reaches zero without replacing their host element. Add browser regression coverage for rapid margin and padding changes, asserting that the overlay remains visible, connected, and represented by the same DOM node throughout the edits.
Refresh projective handles after history changes and throughout CSS transform transitions so undo and redo keep the active overlay aligned with the restored element geometry. Suppress standard selection overlays instead of deleting them, preserve their original display values, and restore them before another VisBug tool initializes. Prevent modifier-key handling from exposing suppressed overlays. Delay outside-click registration past selection-menu activation and add browser coverage for transition-aware undo, safe tool changes, overlay restoration, and existing scroll and interaction behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.