Skip to content

Bump axios due to security vulnerability#12

Closed
rcarmo wants to merge 2 commits intonode-red:masterfrom
rcarmo:patch-1
Closed

Bump axios due to security vulnerability#12
rcarmo wants to merge 2 commits intonode-red:masterfrom
rcarmo:patch-1

Conversation

@rcarmo
Copy link
Copy Markdown

@rcarmo rcarmo commented Dec 22, 2020

axios/axios#3410

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Comment thread package.json
"dependencies": {
"axios": "0.21.1",
"bcryptjs": "^2.4.3",
"axios": "^0.21.1",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix the issue ? Why not ensure it is the correct level to fix the issue raised ?

Comment thread package.json
"axios": "0.19.2",
"bcryptjs": "^2.4.3",
"axios": "^0.21.1",
"bcryptjs": "^5.0.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 5.x version of bcryptjs - the latest is 2.4.3 which is the version we had listed already.

@knolleary
Copy link
Copy Markdown
Member

Resolved via #13

@knolleary knolleary closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants