Skip to content

Bump axios due to security vulnerability #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rcarmo wants to merge 2 commits into from
+2 −2
Closed

Bump axios due to security vulnerability #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24fbe53
Bump axios due to security vulnerability
rcarmo Dec 22, 2020
03b0920
Bump bcryptjs
rcarmo Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"test": "./node_modules/.bin/mocha "
},
"dependencies": {
"axios": "0.19.2",
"bcryptjs": "^2.4.3",
"axios": "^0.21.1",
Copy link
Copy Markdown
Member

@dceejay dceejay Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix the issue ? Why not ensure it is the correct level to fix the issue raised ?

"bcryptjs": "^5.0.0",
Copy link
Copy Markdown
Member

@knolleary knolleary Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 5.x version of bcryptjs - the latest is 2.4.3 which is the version we had listed already.

"cli-table": "^0.3.1",
"minimist": "^1.2.5",
"read": "^1.0.7"
Expand Down