Add the serverUri as trusted origin for multiuser #1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjetilk
requested review from
RubenVerborgh,
dmitrizagidulin,
megoth and
rubensworks
ghost
assigned
megoth
approved these changes
Dec 20, 2018
| resourcePath += '/' | ||
| } | ||
|
|
||
| let trustedOrigins = [ldp.resourceMapper.resolveUrl(req.hostname)].concat(ldp.trustedOrigins) |
Contributor
There was a problem hiding this comment.
An even more readable version would be to have it in separate function; but this is good ^_^
| } | ||
|
|
||
| let trustedOrigins = [ldp.resourceMapper.resolveUrl(req.hostname)].concat(ldp.trustedOrigins) | ||
| if (ldp.multiuser) { |
Contributor
There was a problem hiding this comment.
Shouldn't we also include serverUri as a trusted origin in single-user mode?
Member
Author
There was a problem hiding this comment.
Yeah, so the resolveUrl(req.hostname) would then be that... So, you could turn this patch around, actually, with the same result. I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1026 .