-
Notifications
You must be signed in to change notification settings - Fork 305
[WIP] Consent screen #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Consent screen #1187
Conversation
|
Oh nice, this is much-needed work! |
default-views/auth/consent.hbs
Outdated
| <div class="page-title"> | ||
| <h1>Authorize app to use your Web ID?</h1> | ||
| <h1>Authorize this app to use your data?</h1> | ||
| <p>You will be authorizing <strong>{{app_origin}}</strong> to have access perform the actions indicated below.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
access "to" perform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from that one unit test you said isn't passing yet
| request.setUserConsent(appOrigin) | ||
| request.redirectPostConsent() | ||
| } else { | ||
| request.renderForm(null, req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ap from a session if not trusted anymore
This should be merged in parallel with nodeSolidServer/oidc-auth-manager#41.