Skip to content

Conversation

@jaxoncreed
Copy link
Contributor

@jaxoncreed jaxoncreed commented May 13, 2019

This should be merged in parallel with nodeSolidServer/oidc-auth-manager#41.

@dmitrizagidulin
Copy link
Contributor

Oh nice, this is much-needed work!

<div class="page-title">
<h1>Authorize app to use your Web ID?</h1>
<h1>Authorize this app to use your data?</h1>
<p>You will be authorizing <strong>{{app_origin}}</strong> to have access perform the actions indicated below.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

access "to" perform

Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from that one unit test you said isn't passing yet

request.setUserConsent(appOrigin)
request.redirectPostConsent()
} else {
request.renderForm(null, req)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ap from a session if not trusted anymore

@kjetilk kjetilk merged commit 7adbe1c into master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants