Skip to content

Created a docker-compose file for development purpose #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelo-v merged 3 commits into from
Jan 21, 2022
Merged

Created a docker-compose file for development purpose #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb9cc72
it was created a docker-compose file for development purpose. It's fa…
paulorodriguesxv Dec 20, 2021
128955d
Readme instructions adjustments
paulorodriguesxv Dec 21, 2021
be9c1de
Readme adjustments - replace colon by M-dash
paulorodriguesxv Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ FROM node:lts
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app
COPY package.json /usr/src/app/
COPY package-lock.json /usr/src/app/
RUN npm install
COPY . /usr/src/app

Expand Down
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,19 +237,25 @@ We have automatic builds set up, so commits to master will trigger a build of ht

### Development usage

If you want to use Docker in development, then you can build it locally with:
If you want to use Docker in development, you can build and run the image locally with either docker-compose —

```bash
git clone https://github.com/solid/node-solid-server
cd node-solid-server
docker build -t node-solid-server .
docker-compose up -d
```

Run with:
— or these manual commands —

```bash
git clone https://github.com/solid/node-solid-server
cd node-solid-server
docker build -t node-solid-server .

docker run -p 8443:8443 --name solid node-solid-server
```


This will enable you to login to solid on https://localhost:8443 and then create a new account
but not yet use that account. After a new account is made you will need to create an entry for
it in your local (/etc/)hosts file in line with the account and subdomain, i.e. --
Expand Down
10 changes: 10 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
version: "3"
services:
solid-server:
build: .
container_name: solid
ports:
- "8443:8443"
entrypoint: npm run solid start -- --no-reject-unauthorized

@angelo-v angelo-v Jan 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question Why is --no-reject-unauthorized added? And why is the same(?) thing added as an env variable below as well?

@paulorodriguesxv paulorodriguesxv Jan 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @angelo-v

Because it's exactly same thing that bin/solid-test is doing, as you can see:

// Disable rejectUnauthorized when starting the server
if [ "$COMMAND" == "start" ]; then
ADD_FLAGS="--no-reject-unauthorized"
export NODE_TLS_REJECT_UNAUTHORIZED=0
fi

Respectfully speaking and excuse my sincerity, but this is simple docker-compose to help developer (like me) to running up application easily. But it is stuck in here for a long 1 month and ithas been generating so much questions that seems unbelieve to me.. Please feel free to decline.

@angelo-v angelo-v Jan 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint @paulorodriguesxv I now understand and I think we can just merge it.

I totally understand your frustration. Unfortunately node-solid-server does not get much attention from the community anymore. Only a tiny group of volunteers keeping an eye on it more or less. I have the permission to merge and will do it, but I am not a NSS maintainer in any regard

environment:
- NODE_TLS_REJECT_UNAUTHORIZED=0