Improve the error messaging for permissions #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invalid setup with directory permissions happened, it doesn't mean an invalid port. It usually implies it is a setup error. Add the handling for the mkdir sys call.
Member
|
Wooohooo, our first PR after the website went up! Thanks a lot, @mohamedmansour , that's awesome! We're just about to publish a process on how we deal with PRs, we'll discuss that shortly. @dmitrizagidulin care to review? |
dmitrizagidulin
approved these changes
Sep 29, 2018
Contributor
dmitrizagidulin
left a comment
dmitrizagidulin
left a comment
There was a problem hiding this comment.
Thanks @mohamedmansour! Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid setup with directory permissions happened, it doesn't mean an invalid port. It usually implies it is a setup error. Add the handling for the mkdir sys call.
Fixes #800