-
Notifications
You must be signed in to change notification settings - Fork 305
Add private folder to template #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
60ea133 to
e92d009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uncertain about target="_blank", but apart from that it looks good.
| <span class="lead">Public Folder</span> | ||
| <span class="badge">public</span> | ||
| </a> | ||
| <a href="/private/" target="_blank" class="list-group-item"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary with target="_blank"? It's usually an annoyance for most use cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a "Good reason" (ref https://css-tricks.com/use-target_blank/) for doing this, but maybe there's something I'm missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste from what was above.
But a good reason would be that the click brings them to Databrowser, which might be very overwhelming at first. They can just close and be back on the homepage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's continue that practice for now then
|
This fell off my radar... We're go to merge? In which case, it should be on the ASAP board. |
|
Yes, this could be merged; want me to rebase it on master? |
|
Should be rebased and ready for merging now. |
|
Seems like a merge, not a rebase. (And a rebase isn't strictly needed, but
can be done.)
|
|
Gah, my git skills are not the best, especially rebase is something I haven't quite understood yet. But hope the result looks good nevertheless. |
|
Don't merge yet, will fix tonight.
|
|
Regarding |
|
Yes, but this is a local redirect so not an issue.
|
d694dc3 to
0f6cd51
Compare
|
@megoth For reference, here are the steps I took: git checkout master
git pull
git checkout feature/private-folder # my local copy was still un-rebased
git rebase master
git push -fNote how there is only 1 commit in this PR now. |
|
OK, great! We've deprecated |
I watched a new Solid user figure out how to upload stuff to a place no one could see.
Turns out it's hard/unintuitive to create this in the UI:
/is hard, because there is an HTML page there, not Databrowser;While this PR doesnm't mitigate the above two issues, at least it provide a private folder by default, which is probably a sensible thing to do.